Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse angular brackets in steps only for "Scenario Outline"s #524

Merged
merged 6 commits into from Jul 4, 2022

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Jul 3, 2022

Parse step parameters in angular brackets only when used in "Scenario Outline"s.

Fixes #447

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #524 (384c023) into master (a75fc05) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   92.69%   92.62%   -0.07%     
==========================================
  Files          48       48              
  Lines        1642     1655      +13     
  Branches      176      178       +2     
==========================================
+ Hits         1522     1533      +11     
- Misses         82       83       +1     
- Partials       38       39       +1     
Impacted Files Coverage Δ
tests/feature/test_cucumber_json.py 92.59% <ø> (ø)
tests/feature/test_report.py 75.67% <ø> (ø)
pytest_bdd/parser.py 97.00% <83.33%> (-0.92%) ⬇️
pytest_bdd/scenario.py 89.53% <100.00%> (ø)
tests/feature/test_scenario.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75fc05...384c023. Read the comment docs.

@youtux youtux merged commit 7e218c3 into master Jul 4, 2022
@youtux youtux deleted the scenario-template-args branch July 4, 2022 14:16
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: KeyError in replacer
1 participant