New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override language #345
Open
napolas
wants to merge
12
commits into
pytest-dev:master
Choose a base branch
from
napolas:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Override language #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll as gherkin terminal output consistent with the overriden language
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 94.99% 95.84% +0.85%
==========================================
Files 57 58 +1
Lines 2217 2240 +23
Branches 185 187 +2
==========================================
+ Hits 2106 2147 +41
+ Misses 73 62 -11
+ Partials 38 31 -7
Continue to review full report at Codecov.
|
napolas
force-pushed
the
master
branch
2 times, most recently
from
January 17, 2020 11:22
87accb9
to
99d83e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we override the language by redefining the "types" constants, the terminal reporting as well as the cucumber.json output does not follow as expected.
Although this is not an I18N proper solution, it allows one to override the types constants and even so the reporting tools work in consistent fashion.