Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override language #345

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Override language #345

wants to merge 12 commits into from

Conversation

napolas
Copy link

@napolas napolas commented Jan 10, 2020

When we override the language by redefining the "types" constants, the terminal reporting as well as the cucumber.json output does not follow as expected.
Although this is not an I18N proper solution, it allows one to override the types constants and even so the reporting tools work in consistent fashion.

…ll as gherkin terminal output consistent with the overriden language
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #345 into master will increase coverage by 0.85%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   94.99%   95.84%   +0.85%     
==========================================
  Files          57       58       +1     
  Lines        2217     2240      +23     
  Branches      185      187       +2     
==========================================
+ Hits         2106     2147      +41     
+ Misses         73       62      -11     
+ Partials       38       31       -7
Impacted Files Coverage Δ
pytest_bdd/gherkin_terminal_reporter.py 85.88% <100%> (+0.69%) ⬆️
tests/feature/test_function.py 100% <100%> (ø)
pytest_bdd/feature.py 99.26% <100%> (+3.02%) ⬆️
pytest_bdd/cucumber_json.py 92.94% <100%> (+2.81%) ⬆️
pytest_bdd/parsers.py 87.75% <0%> (+4.08%) ⬆️
pytest_bdd/scripts.py 91.48% <0%> (+4.25%) ⬆️
tests/steps/test_unicode.py 100% <0%> (+6.45%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b92bd...11d41ff. Read the comment docs.

@napolas napolas force-pushed the master branch 2 times, most recently from 87accb9 to 99d83e9 Compare January 17, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants