Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PyWeb as part of stdlib on MicroPython #2030

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Avoid PyWeb as part of stdlib on MicroPython #2030

merged 2 commits into from
Apr 17, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR goal is to unlock #1960 issues with MicroPython currently being unable to deal with too much code to run at once: see micropython/micropython#14307

Changes

  • created an ad-hoc solution that is the least obtrusive around our stack, so that we can fine-tune what's undesired on specific target side (in this case the mpy custom type)
  • test results are satisfying all over the place

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

ntoll
ntoll approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

FabioRosado
FabioRosado approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a question for learning purposes haha

pyscript.core/src/stdlib.js Show resolved Hide resolved
@WebReflection WebReflection merged commit cf92996 into pyscript:main Apr 17, 2024
2 checks passed
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Apr 17, 2024
@WebReflection @pre-commit-ci
Avoid PyWeb as part of stdlib on MicroPython (pyscript#2030)
d10f069 
* Avoid PyWeb as part of stdlib on MicroPython

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioRosado FabioRosado FabioRosado approved these changes

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WebReflection @ntoll @FabioRosado