ViewBox: Only update auto-range before painting. #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of recalculating autorange for each call to addItem, defer the calculation until the next paint event. I was experiencing a lot of lag when creating >1000 curve items with 100 points each. Profiling showed that 70% of the runtime was spent in updateAutoRange. With this patch, updateAutoRange is less than 1% of the runtime.
|
Here be dragons in this part of the code, would need to test on a number of platforms, and with log-mode to ensure plots are behaving as appropriate. I can't remember which PR touched on this last (would need to look at git blame) but we had some very undesirable consequences if memory serves... |
|
I completely understand! Give me some time and I can make an example script and open an issue. If this PR doesn't work out, we can still track the performance issue and discuss other solutions. |
|
Not trying to suggest this PR is a nogo, just that it would need more scrutiny than one would think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of recalculating autorange for each call to addItem, defer the calculation until the next paint event.
I was experiencing a lot of lag when creating >1000 curve items with 100 points each. Profiling showed that 70% of the runtime was spent in updateAutoRange. With this patch, updateAutoRange is less than 1% of the runtime.