Update ASV config to use paramers #2776
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
j9ac9k
force-pushed
the
update-asv-for-images
branch
2 times, most recently
from
d76cf91
to
6649574
Compare
j9ac9k
force-pushed
the
update-asv-for-images
branch
3 times, most recently
from
1ccbb3e
to
4e4a651
Compare
benchmarks/renderImageItem.py
Outdated
| for size in self.params.sizes: | ||
| size_with_channels = (size[0], size[1], channels) if channels != 1 else size | ||
| if xp.dtype(dtype) in (xp.float32, xp.float64): | ||
| data = xp.random.default_rng().standard_normal( |
There was a problem hiding this comment.
Calling default_rng() instantiates a new Generator object. Was that intended or could a single Generator object be used?
There was a problem hiding this comment.
I just went w/ the example in the docs; you're right, should probably just use a single generator object
j9ac9k
force-pushed
the
update-asv-for-images
branch
from
4e4a651
to
dc1740f
Compare
CONTRIBUTING.md
Outdated
| python setup.py asv_config | ||
| asv config |
There was a problem hiding this comment.
Error running this command:
(asv-test) PS C:\Users\...\pyqtgraph> asv config
usage: asv [-h] [--verbose] [--config CONFIG] [--version]
{help,quickstart,machine,setup,run,dev,continuous,find,rm,publish,preview,profile,update,show,compare,check,gh-pages} ...
asv: error: argument {help,quickstart,machine,setup,run,dev,continuous,find,rm,publish,preview,profile,update,show,compare,check,gh-pages}: invalid choice: 'config' (choose from 'help', 'quickstart', 'machine', 'setup', 'run', 'dev', 'continuous', 'find', 'rm', 'publish', 'preview', 'profile', 'update', 'show', 'compare', 'check', 'gh-pages')
There was a problem hiding this comment.
That's what I get for going off memory, pretty sure it should be asv setup
There was a problem hiding this comment.
Do tests require python 3.11? If so, might be worth specifying in the docs
(asv-test) PS C:\Users\ntjess\Desktop\git\pyqtgraph> asv setup
· No executable found for python 3.11
· No executable found for python 3.11
· No executable found for python 3.11
Disregard, I see it earlier
There was a problem hiding this comment.
Huh; I'm fairly certain I tested on Python 3.11... haven't seen that error before tho
j9ac9k
force-pushed
the
update-asv-for-images
branch
from
dc1740f
to
802ef55
Compare
renderImageItemnow uses parameterization better to keep track of attributes of a given testcupyversion is better detectedPYQTGRAPH_QT_LIB's are cycled through forcing the use of different Qt bindings.TODO: