Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter tree size hint overloads #2537

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntjess
Copy link
Contributor

@ntjess ntjess commented Nov 26, 2022

I might be missing something, so it would be great for others to verify. On my machine, parameter tree & item sizing appears to work better by removing all custom size hint logic... The biggest difference is spawning a window with just a parameter tree

  • Before this change, the window had to be manually resized to fit all parameters
  • Now, (for me) the window is correctly sized immediately.

@ntjess ntjess marked this pull request as draft November 26, 2022 01:34
@j9ac9k
Copy link
Member

j9ac9k commented Jan 19, 2023

This is what it looks like on master for me:

image

This is what it looks like on your branch

image

Not seeing too much of a difference there, but on initial launch of the parametertree example:

Master:
image

This branch:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants