Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first round at self shielding #849

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

FlanFlanagan
Copy link
Contributor

@scopatz updates to self shielding pyne side.

@scopatz scopatz added the feature label Jun 3, 2016
@scopatz scopatz added this to the v0.6 milestone Jun 3, 2016
@@ -362,7 +383,6 @@ def discretize(self, nuc, rx, temp=300.0, src_phi_g=None, dst_phi_g=None):
Temperature [K] of material, defaults to 300.0.
src_phi_g : array-like, optional
IGNORED!!! Included for API compatability
dst_phi_g : array-like, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line removed?

@scopatz
Copy link
Member

scopatz commented Jun 3, 2016

Thanks for putting this in @FlanFlanagan! Please ping when you think that it is ready for another look.

if j != i:
weights[i] += num_dens[j]*self.reaction(j, 'total', temp)
weights[i] = 1.0/(weights[i]/num_dens[i] + self.reaction(i, 'total', temp))
print(weights)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra print statement

@makeclean
Copy link
Contributor

@FlanFlanagan could you rebase against develop and push again?

@gonuke gonuke modified the milestones: v0.6, Deferred Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants