fix mcnp6 version check for serial #1454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonuke
requested changes
Jun 23, 2022
| @@ -1231,7 +1231,7 @@ def read_variable_ids(self): | |||
|
|
|||
| if self.eightbytes: | |||
| mcnp_version = self.mcnp_version_info[8:13] | |||
There was a problem hiding this comment.
Is it more robust to strip() the whitespace from the end of this?
Suggested change
| mcnp_version = self.mcnp_version_info[8:13] | |
| mcnp_version = self.mcnp_version_info[8:13].strip() |
There was a problem hiding this comment.
Sure, but I like @zxkjack123 to make the change and what he thinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix for Ptrac version check.
Behavior
The below code fails when the Ptrac is generated with the serial mcnp6:
pyne/pyne/mcnp.py
Lines 1233 to 1234 in 800c75a
This PR fixes this problem.