[WIP] Update atomic masses to AME2020 #1385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The KAERI data website is back online as of tonight. However the link format PyNE dbgen kaeri.py is using to pull data from (e.g. http://atom.kaeri.re.kr/cgi-bin/nuclide?nuc=K) is 404ing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Atomic Mass Data Center (AMDC) released an updated Atomic Mass Evaluation (AME2020) dataset in March. This is a work-in-progress PR to update from the old AME2016 data (#1281).
Motivation and Context
Updates atomic mass unit data.
Changes
AME mass data update.
Behavior
Atomic mass data changes slightly.
Other Information
I think the core source updates are OK - they are a copy of PR #1281's code changes, as well as one regex update due to a format change between AME2016 and AME2020.
However running
nuc_data_make --clean 2 --fetch-prebuilt False --make atomic_mass,materialsis currently unsuccessful for building the new nuclear data. The issues are described in #1333. The first problem is KAERI data is no longer hosted on data.pyne.io. I got around this by hosting the kaeri.zip on my website and using that link, but then I ran up against the super-heavy elements issue and downloads failing as KAERI's data website is offline.Once #1333 and pyne/data # 24 are ready, I will return to this PR and complete the second step needed - updating all the tests.
Changelog file
Will fill out changelog once everything is successful.