Fix issues with empty mds_line #1375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did CI not launch? |
|
Ah there we go |
gonuke
requested changes
May 26, 2021
| @@ -1507,6 +1507,9 @@ def mat_from_inp_line(filename, mat_line, densities='None'): | |||
| # set metadata | |||
| line_index += 1 | |||
| mds_line = linecache.getline(filename, mat_line - line_index) | |||
| # its possible this line is blank and will fail on the .split operation | |||
There was a problem hiding this comment.
which split fails? A completely blank line is not valid MCNP input. Do you have an example that fails?
|
Also needs an addition the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow these guidelines when making a Pull Request.
This template was adapted from here and here.
Description
Fixed a bug that occured upon reading a material
Motivation and Context
Fixes a material reading bug
Changes
Bug fix
Behavior
Broken now fixed
Other Information
N/A