Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT-CADIS workflow, step 0 for SNILB criteria check #1082

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GT-CADIS workflow, step 0 for SNILB criteria check #1082

wants to merge 2 commits into from

Conversation

moatazharb
Copy link

This PR does the following:

Fixes #987 (the optional step for GT-CADIS workflow)
Changes to gtcadis.py
================
Read material-laden hdf5 geometry file
Write ALARA input files (inp, matlib, fluxin) and run ALARA
Process produced photon source file and calculates SNILB eta value
Save eta values for each material and decay time in a numpy array and text file

Changes to alara.py

Added calc_eta function
Added supporting functions

@moatazharb moatazharb requested a review from gonuke January 7, 2019 17:15
@moatazharb
Copy link
Author

moatazharb commented Jan 7, 2019 •
edited

@gonuke this PR includes all the changes that have been approved in the previous PR for GT-CADIS step 0 #1025. Should be merged once the tests all pass successfully, no need to review as it has already been done in the previous PR.

@gonuke
Copy link
Contributor

gonuke commented Jan 7, 2019

LGTM based on the discussion on #1025 - thanks @moatazharb

zxkjack123
zxkjack123 reviewed Jan 7, 2019
View reviewed changes
scripts/gtcadis.py


if args.command == 'step0':
step0(cfg['general'], cfg['step2'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? cfg['step0']?

@gonuke gonuke added this to the Deferred milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkjack123 zxkjack123 zxkjack123 left review comments

@gonuke gonuke Awaiting requested review from gonuke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Deferred
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moatazharb @gonuke @zxkjack123