Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed halo shape function #782

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Changed halo shape function #782

wants to merge 8 commits into from

Conversation

Morkney
Copy link

@Morkney Morkney commented Mar 15, 2024

I've amended the previous "halo_shape" function into a new "shape" function.

This new version is generalised with respect to particle type (i.e. not limited to dark matter), and can handle both 3D and 2D shape calculations. I think it is more useful this way.

There are also some other minor improvements and simplifications.

@apontzen
Copy link
Member

Thanks Matt. Could you add a test that checks the results, e.g. on the g15784.lr.01024 galaxy in the test data?

@Morkney
Copy link
Author

Morkney commented Mar 19, 2024

Thanks Matt. Could you add a test that checks the results, e.g. on the g15784.lr.01024 galaxy in the test data?

I've added a test for 2D & 3D. Let me know if they're not suitable!
There's some failures on the "pre-commit.ci - pr" checks, but I don't really understand these.
Best, Matt

@apontzen
Copy link
Member

pre-commit.ci autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants