TipsySnap._write_array_metafile(): write dtype correctly. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also completes documentation to the _get_array_metafile() method.
|
Hmm, the tests on your patch are failing with errors like: Your local installation as reported on #705 has an exceptionally old version of numpy (1.16) and python (3.7). I wonder if there is some breaking change? The lowest officially supported version of numpy is 1.21 (as per NEP29), and the tests run against 1.21 and 1.24. That said I'd be happy if there is a fix you can propose that makes it work on your 1.16 installation without also breaking newer installations. |
|
This is always an issue on the big compute resources: they are very conservative in upgrading packages. Such that I can't build the latest version of pynbody on them. |
|
pre-commit.ci autofix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also completes documentation to the _get_array_metafile() method.
Addresses issue #705