-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread-safe access #952
Draft
bilderbuchi
wants to merge
12
commits into
master
Choose a base branch
from
threaded-access
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Thread-safe access #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bmoneke I think I need your help -- my tests uncovered that the Keithley2306
Channel , and also probably that custom Channel (
I guess we overlooked that one during the Channel transition. Can I fix this quickly without getting bogged down, or is that more restructuring work, in your opinion? edit: see #953 |
bilderbuchi
force-pushed
the
threaded-access
branch
2 times, most recently
from
July 22, 2023 14:56
3758a48
to
79ec2d0
Compare
We added channels, but never moved all instruments to channels, see #746 |
This guards against another thread stealing a reply from the instrument's read buffer.
The event was not actually active.
The event-equipped FakeInstrument is getting quite messy, already.
bilderbuchi
force-pushed
the
threaded-access
branch
from
September 3, 2023 09:55
79ec2d0
to
7b1af71
Compare
bilderbuchi
force-pushed
the
threaded-access
branch
from
September 3, 2023 10:25
7b1af71
to
4d4d710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #506, supersedes #608.