Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/thorlabs kpz101 #1057

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

ophirauslaender
Copy link

I added ThorLabs KPZ101. It works on my desktop.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 57.56%. Comparing base (6615798) to head (9a51f42).

Files Patch % Lines
pymeasure/instruments/thorlabs/thorlabskpz101.py 1.56% 63 Missing ⚠️
pymeasure/adapters/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   57.76%   57.56%   -0.21%     
==========================================
  Files         254      255       +1     
  Lines       17672    17737      +65     
==========================================
+ Hits        10209    10211       +2     
- Misses       7463     7526      +63     
Flag Coverage Δ
unittests 57.56% <3.03%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger
Copy link
Member

Hey @ophirauslaender , it is great to see a new contributor and a new device. Thanks for uploading.

Currently we do not support devices which require a manufacturer's library (the dll's for this device).

Maybe we could open an additional repository for such kind of devices. In #1058 I opened such a discussion question.

@ophirauslaender
Copy link
Author

ophirauslaender commented Mar 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants