-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/thorlabs kpz101 #1057
base: master
Are you sure you want to change the base?
Dev/thorlabs kpz101 #1057
Conversation
…ork and match the manual.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
- Coverage 57.76% 57.56% -0.21%
==========================================
Files 254 255 +1
Lines 17672 17737 +65
==========================================
+ Hits 10209 10211 +2
- Misses 7463 7526 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @ophirauslaender , it is great to see a new contributor and a new device. Thanks for uploading. Currently we do not support devices which require a manufacturer's library (the dll's for this device). Maybe we could open an additional repository for such kind of devices. In #1058 I opened such a discussion question. |
I understand. I'll follow the discussion.
I am about to incorporate another kind of instrument (from MadCityLabs)
into the pymeasure framework. I'll do it on my own branch.
Thanks for taking the time to look into this!
Ophir Auslaender, PhD
Research Scientist
…On Mon, Mar 4, 2024 at 12:45 PM Benedikt Burger ***@***.***> wrote:
Hey @ophirauslaender <https://github.com/ophirauslaender> , it is great
to see a new contributor and a new device. Thanks for uploading.
Currently we do not support devices which require a manufacturer's library
(the dll's for this device).
Maybe we could open an additional repository for such kind of devices. In
#1058 <#1058> I opened such
a discussion question.
—
Reply to this email directly, view it on GitHub
<#1057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLXNU2EJ4ZIEKMJLHF4VEDYWSXLJAVCNFSM6AAAAABEFP4OOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGEZTKMBZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…o dev/thorlabs-kpz101" This reverts commit b4633d0.
…der/pymeasure into dev/thorlabs-kpz101
I added ThorLabs KPZ101. It works on my desktop.