Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ophir powermeters #1053

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

BenediktBurger
Copy link
Member

Adds Ophir powermeters.

Several share the same commands, therefore I have a large base class and mixin classes for device groups.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 86.89956% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 58.06%. Comparing base (4846672) to head (f470460).

Current head f470460 differs from pull request most recent head 509cdb0

Please upload reports for the commit 509cdb0 to get more accurate results.

Files Patch % Lines
pymeasure/instruments/ophir/ophir_base.py 85.44% 23 Missing ⚠️
pymeasure/instruments/ophir/nova.py 83.72% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   58.48%   58.06%   -0.43%     
==========================================
  Files         262      258       -4     
  Lines       18198    17867     -331     
==========================================
- Hits        10643    10374     -269     
+ Misses       7555     7493      -62     
Flag Coverage Δ
unittests 58.06% <86.89%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant