Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tektronix MSO Scope Series #1033

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

OptimisticBeliever
Copy link
Contributor

Two child classes have been tested with devices MSO58 and MSO64.

@BenediktBurger
Copy link
Member

Thanks for your contribution.
I had already a quick look a few days ago, but it is a large PR and will take some time.

A few quick points:

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 75 lines in your changes are missing coverage. Please review.

Project coverage is 58.24%. Comparing base (4846672) to head (ca0806f).

Current head ca0806f differs from pull request most recent head 7caed76

Please upload reports for the commit 7caed76 to get more accurate results.

Files Patch % Lines
...easure/instruments/tektronix/tektronixMsoSeries.py 70.47% 75 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   58.48%   58.24%   -0.24%     
==========================================
  Files         262      257       -5     
  Lines       18198    18087     -111     
==========================================
- Hits        10643    10535     -108     
+ Misses       7555     7552       -3     
Flag Coverage Δ
unittests 58.24% <70.58%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger
Copy link
Member

By the way, you do not have to cover all lines with tests.

…gth, horizontal_sample_rate, horizontal_delay_mode, horizontal_minsamplerate_override, horizontal_minsamplerate_value, horizontal_delay_time properties to class TektronixMsoScope
Add methods add_new_math and math_delete_all to class TektronixMsoScope
Add test_math_fft
@OptimisticBeliever
Copy link
Contributor Author

Thanks for your contribution. I had already a quick look a few days ago, but it is a large PR and will take some time.

A few quick points:

Hello Benedikt,
no this device is not linked to keithley instruments.
Anyway could you please what is wrong in the Docs and Linting auto check. I could not figure it out !

Thanks,

Copy link
Member

@BenediktBurger BenediktBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, what causes the issue, but marked two points, where it could be.

You can check it on your computer, if you run make html in a console (not python console) in the docs directory.

Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
OptimisticBeliever and others added 20 commits April 9, 2024 09:17
Change the MEAS_SLOTS list values
Change the EXPECTED_MEAS_VALUES keys
Add the MEASURABLE_PARAMETERS

Add the test_measurement_add
Add the break_on_termchar=True in method download_image
Add a validator and values to the horizontal_record_length property
Add waveform_data_source, waveform_points, waveform_first_point, waveform_last_point, waveform_preamble properties
Add _fill_yaxis_preamble, _digitize, _header_footer_sanity_checks, _npoints_sanity_checks, _acquire_data, _process_data, download_waveform methods
set map_values=False for bwlimit property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants