-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tektronix MSO Scope Series #1033
base: master
Are you sure you want to change the base?
Add Tektronix MSO Scope Series #1033
Conversation
Add the test with and without device
Add the measurement_gating properties
Thanks for your contribution. A few quick points:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 58.48% 58.24% -0.24%
==========================================
Files 262 257 -5
Lines 18198 18087 -111
==========================================
- Hits 10643 10535 -108
+ Misses 7555 7552 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
By the way, you do not have to cover all lines with tests. |
…gth, horizontal_sample_rate, horizontal_delay_mode, horizontal_minsamplerate_override, horizontal_minsamplerate_value, horizontal_delay_time properties to class TektronixMsoScope
Add methods add_new_math and math_delete_all to class TektronixMsoScope
Add test_math_fft
Hello Benedikt, Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, what causes the issue, but marked two points, where it could be.
You can check it on your computer, if you run make html
in a console (not python console) in the docs directory.
Co-authored-by: Benedikt Burger <67148916+BenediktBurger@users.noreply.github.com>
…to {.."lowpass": "LFREJ", "highpass": "HFREJ"..} for the _TRIGGER_COUPLING dictionary
Update the trigger_edge_source and trigger_width_source properties
Add the test_trigger_width_source Update the test_measurement_configure
Change the MEAS_SLOTS list values Change the EXPECTED_MEAS_VALUES keys Add the MEASURABLE_PARAMETERS Add the test_measurement_add
Add the break_on_termchar=True in method download_image
Add a validator and values to the horizontal_record_length property Add waveform_data_source, waveform_points, waveform_first_point, waveform_last_point, waveform_preamble properties Add _fill_yaxis_preamble, _digitize, _header_footer_sanity_checks, _npoints_sanity_checks, _acquire_data, _process_data, download_waveform methods
set map_values=False for bwlimit property
…Hz"], [1.0000E+9, "1GHz"]]
Two child classes have been tested with devices MSO58 and MSO64.