Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 155: single source of version, setuptools -> flit #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpreszler
Copy link
Contributor

@jpreszler jpreszler commented Sep 15, 2023

This should resolve issue #155 , but I couldn't get setuptools to do dynamic versioning because of the imports in __init__.py. Switching to flit seems to work with minimal changes.

I tested by changing the version locally and using pip install -e . in a clean environment. The version was correct. Also using python -m build produced targ.gz and whl files with the correct versions in names.

Not sure if other testing would be good or if there's further discussion needed before changing the backend build system.

@jpreszler jpreszler changed the title single source of version, setuptools -> flit Issue 155: single source of version, setuptools -> flit Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #239 (33209e2) into main (133b987) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files          19       19           
  Lines        1149     1149           
=======================================
  Hits          849      849           
  Misses        300      300           

@drbenvincent
Copy link
Collaborator

Just checking that this is still a draft PR? When it's ready can you get me and @lucianopaz to review?

@jpreszler jpreszler marked this pull request as ready for review September 18, 2023 21:15
@jpreszler
Copy link
Contributor Author

@drbenvincent and @lucianopaz , I've cleaned this up and it's ready for review.

I looked into bump2version but it seemed like it would involve more changes because it's an external command line tool, but would work if there's strong desire to keep setuptools as the build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants