Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to setup-micromamba action #7213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Mar 22, 2024

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7213.org.readthedocs.build/en/7213/

@maresb maresb force-pushed the setup-micromamba branch 2 times, most recently from fedefb7 to c490e50 Compare March 22, 2024 14:50
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.92%. Comparing base (bd74474) to head (03bebb6).

❗ Current head 03bebb6 differs from pull request most recent head bf491b6. Consider uploading reports for the commit bf491b6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7213       +/-   ##
===========================================
+ Coverage   55.50%   75.92%   +20.41%     
===========================================
  Files         101      100        -1     
  Lines       16862    16875       +13     
===========================================
+ Hits         9360    12813     +3453     
+ Misses       7502     4062     -3440     

see 68 files with indirect coverage changes

@maresb maresb marked this pull request as ready for review March 22, 2024 16:03
@maresb
Copy link
Contributor Author

maresb commented Mar 22, 2024

I think the error may be fixed here: pymc-devs/pytensor#678

@maresb
Copy link
Contributor Author

maresb commented Mar 29, 2024

Ah ya, thanks, that's the one! (Wrong PR)

Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much simpler.

@ricardoV94
Copy link
Member

Do we need pymc-devs/pytensor#678 here?

@twiecki
Copy link
Member

twiecki commented Apr 5, 2024

Worth a try.

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

Ok, rebased.

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

That's weird, maybe it needs to be rerun?

image

I still find GH's UI here weird. I can't find a rerun button for that task. Maybe I need to wait until the whole thing finishes?

@ricardoV94
Copy link
Member

Yeah, you can only rerun failed runs once everything is done

@maresb
Copy link
Contributor Author

maresb commented Apr 5, 2024

Just started the rerun. Any idea why I can't view logs (see screenshot)? Is this a GH outage?

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Viewing the CI logs is still really flaky for me, but somehow I was able to get a glimpse of:

 _________________ ERROR collecting tests/sampling/test_jax.py __________________
tests/sampling/test_jax.py:30: in <module>
    from numpyro.infer import MCMC
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/__init__.py:6: in <module>
    from numpyro import compat, diagnostics, distributions, handlers, infer, ops, optim
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/__init__.py:4: in <module>
    from numpyro.distributions.conjugate import (
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/conjugate.py:9: in <module>
    from numpyro.distributions.continuous import Beta, Dirichlet, Gamma
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/numpyro/distributions/continuous.py:36: in <module>
    from jax.scipy.linalg import cho_solve, solve_triangular
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/jax/scipy/linalg.py:18: in <module>
    from jax._src.scipy.linalg import (
../../../micromamba/envs/pymc-test/lib/python3.12/site-packages/jax/_src/scipy/linalg.py:403: in <module>
    @_wraps(scipy.linalg.tril)
E   AttributeError: module 'scipy.linalg' has no attribute 'tril'

Then for attempt #2, which I believe was post-rebase, I think I was still seeing the old "filename too long" error. 😢 But I can't access the logs in order to paste them here...

Am I the only one who is having trouble viewing the CI logs?

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Regarding scipy.linalg.tril, see https://docs.scipy.org/doc/scipy-1.11.4/reference/generated/scipy.linalg.tril.html:

Deprecated since version 1.11.0: tril is deprecated in favour of numpy.tril and will be removed in SciPy 1.13.0.

@maresb
Copy link
Contributor Author

maresb commented Apr 6, 2024

Yeah, you can only rerun failed runs once everything is done

@ricardoV94, here I at least have a "Re-run" link, even though it doesn't appear to have actually triggered a rerun yet.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants