New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor jax internals to support dense_mass kwarg for numpyro #7050
Open
ferrine
wants to merge
5
commits into
main
Choose a base branch
from
jax-block-adapt
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7050 +/- ##
===========================================
- Coverage 92.19% 79.97% -12.23%
===========================================
Files 101 101
Lines 16893 16911 +18
===========================================
- Hits 15575 13524 -2051
- Misses 1318 3387 +2069
|
ricardoV94
reviewed
Dec 8, 2023
ricardoV94
reviewed
Dec 11, 2023
ricardoV94
approved these changes
Dec 11, 2023
These failing tests are definitely a latest PyTensor issue, I'll patch it |
ricardoV94
changed the title
refactor jax internals to support dense_mass kwarg for numpyro
Refactor jax internals to support dense_mass kwarg for numpyro
Dec 11, 2023
Failing tests due to PyTensor should be fixed by pymc-devs/pytensor#546 |
Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
ferrine
force-pushed
the
jax-block-adapt
branch
from
December 11, 2023 17:26
eae6da8
to
8eb4284
Compare
@ferrine can you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Enables Block Dense mass matrix adaptation for numpyro
Checklist
Major / Breaking Changes
New features
get_jaxified_logp
now acceptspoint_fn
argumentBugfixes
Documentation
Maintenance
馃摎 Documentation preview 馃摎: https://pymc--7050.org.readthedocs.build/en/7050/