Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working instructions for CentOS #47

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

itsmesatwik
Copy link

Created a script for setting up the latest cmake instead of default and updated instructions for centos.

@itsmesatwik
Copy link
Author

@dogancan Would be great if you could review the added instructions.

@dogancan
Copy link
Member

Here are some notes for the current PR. I'll do another pass when you confirm you have a working installation.

I think we can get rid of install_cmake.sh script by checking if cmake3 binary exists on the path and using that inside setup.py. Then in the readme we can just give two separate command lines for apt and yum and the rest of the instructions would stay as they are now.

@dogancan
Copy link
Member

Hey @itsmesatwik. Have you managed to get the install instructions working on centos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants