Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testserver.py reverting upstream change #119

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andreagalle
Copy link
Contributor

The .self.path.endswith( are necessary, as well as the "cross-origin-embedder-policy", "unsafe-none" header.

  • Which sense this header is buggy, as the comment states?
  • Does it make sense to apply the same patch ( .self.path.endswith( ) even to the lines here below?
107        if path.endswith("/"):

...

114        invalid = path.endswith(".map") or path.endswith(".apk")

The `.self.path.endswith(` are necessary, as well as the `"cross-origin-embedder-policy", "unsafe-none"` header.
@pmp-p
Copy link
Member

pmp-p commented Sep 26, 2023

for things that are clear to me:

  • testing path is faster because it's a local
  • path does not have ? # trail so it works with endswith() unlike self.path which is full url from http request

for those which are not:

The comment is a silly remnant of some blind experimentation.
But it could be changed to without "require-corp" or "credentialless" Atomics/threads/SharedArraybufers won't work.

https://partytown.builder.io/tests/atomics/?coep=require-corp <= seems the one that work better than credentialless and is found on the targeted hosting websites.

Note that the runtime still don't use those fancy features but it may require them in the future so better be ready for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants