This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Create detecting_cyclicgraph.py #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return False | ||
| visited.add(vertex) | ||
| path.add(vertex) | ||
| for neighbour in g.get(vertex, ()): |
There was a problem hiding this comment.
use None instead of empty tuple. As it would be easy for others specially beginners to understand the code.
|
Please check for PEP8 errors. (I see incorrect indentation) Also include test for the Algo. |
|
Your test and the algo should be in the same PR. So close the other PR and include your test here. |
|
Included test just now! @CuriousLearner |
|
@yatingupta10 Please also do the changes mentioned in code diff. |
|
#12. Not in the list of the referenced issue but can be added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.