Using the skeleton and components of sphinx-basic-ng #840
Conversation
| @@ -16,7 +16,7 @@ | |||
| } | |||
|
|
|||
| // Dark theme special-cases | |||
| html[data-theme="dark"] .bd-content { | |||
There was a problem hiding this comment.
Is this intentional? Just a quick thought that we probably don't need to rename our CSS prefix as part of this, right? (Unless we are just using the exact same section classes as basic-ng or something)
There was a problem hiding this comment.
Yes, because I am inheriting most of the HTML from sphinx-basic-ng, which has classes name 'sb-' etc. So had to update the CSS here. My thinking was that if we inherit the skeleton, we will just be updating the styles, etc inherited. Instead of updating the HTML as far as we can.
|
Thanks, @choldgraf for looking into this. Although I will probably keep this as a record of changes for now, and focus on getting this PR: executablebooks/sphinx-book-theme#597 completed. After that will create a new PR in this repo leveraging the learnings in this PR to inherit the components only first. |
|
I'm going through all PRs and see if I can bring them up to date. This has not been touched in 1+ year, is still in draft, and has a lot of conflict, so just in order to keep the list of open PR smaller I'm going to close it for now, but we can reopen if needed. Thanks, |
This is just an experimentation PR, meant to showcase the feasibility of swapping the skeleton.
Although this is not a good first step to switching to
sphinx-basic-ngas the base, we should start with inheriting only the components. But nevertheless, I experimented with it a bit. This PR is an update on the work, and I will update the description shortly with the things done.