New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning when set "alias" in low level annontated field #9170
Add warning when set "alias" in low level annontated field #9170
Conversation
CodSpeed Performance ReportMerging #9170 will not alter performanceComparing Summary
|
please review. |
Great work here, thanks! Will merge once tests pass - I made a few minor modifications to function names + warning wording. |
Sorry - not sure what exactly the last linting issue is with the test file - could you check locally? Other than that, we're good to merge! |
@sydney-runkle resolved the linting. Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here, thanks!
Change Summary
Add warning message when user setup annotated field with
alias
kwarg at low level. #7828.Related issue number
Checklist
Fix #7828
Selected Reviewer: @adriangb