-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROB: improve inline image extraction #2622
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
==========================================
+ Coverage 95.02% 95.07% +0.04%
==========================================
Files 50 51 +1
Lines 8366 8490 +124
Branches 1674 1694 +20
==========================================
+ Hits 7950 8072 +122
- Misses 258 263 +5
+ Partials 158 155 -3 ☔ View full report in Codecov by Sentry. |
new test file: |
use of: |
@stefan6419846, @MartinThoma, @MasterOdin |
It is rather unlikely that I am able to provide further (real) files for testing. While I have access to lots of PDF files in theory, most of them are confidential. Additionally, the usual routines I use completely omit any inline images as they provide no value for my use cases. If possible, I would indeed prefer to avoid two different implementations of the same filter algorithms - we already have sufficient coverage for the filters outside the inline image extraction and thus re-using them would make more sense and avoid larger coverage issues. |
@stefan6419846 |
add test file for RL encoding: |
Besides the above remarks, there are two bigger issues I would like to talk about:
|
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
@stefan6419846 |
Yes, this is correct. |
closes #2598