Android Support #28
Open
Android Support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge android
Android accuracy
Android telemetry
…bs, that should instead be transitive dependencies, as direct dependency of example app. (For now until we setup jCenter)
Android telemetry
- Changed CMMotionManager reference to be private readonly property - Marked RCTResponseSenderBlock parameters nonnull - Changed property accesses to use modern syntax - Fixed active reporting, which was the opposite - Reduced re-getting data objects in get data methods - Factored out dictionary creation
MC: Accelerometer, Gyroscope, Magnetometer:
|
whoa! this is incredible. I don't really have the time/expertise to properly review this, so I'll just add you as a contributor to this repo/npm module and let you do what's best. Looks like there are other participants here as well, and I'd be happy to do the same for them if you'd like. |
|
@connected-jallen k, you should be all set up with push/publish rights. Thanks again for all the work! |
Android with tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android support and iOS bug fixes and code refactoring to remove code duplication.