Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable calendar popover #142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bkuzma
Copy link

@bkuzma bkuzma commented Nov 1, 2017

Table of Contents

Description

I added a prop called calendarDisabled which prevents a calendar popover from being rendered when the input is focused. I added a corresponding test as well as an example to the example page.

Motivation and Context

This would be useful in cases where the user is entering a date far in the past, such as a birthday, and it's more straightforward to type the date than to click back month by month for possibly dozens of years.

How Has This Been Tested?

I wrote a test which verifies that the popover isn't rendered when the calendarDisabled prop is true. I tested the component in Chrome 61.0.3163.100 on the examples page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant