Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new property todayDate #111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gReis89
Copy link

@gReis89 gReis89 commented Apr 12, 2017

Description

Is it useful to have a property to change the default display date on the popover component, some times, we need the popover to open on a different month or year to be closer to a specific date range.

Motivation and Context

I'm using the component to select some dates in the past, 3 or 4 years in the past, in those cases, it is painful to navigate between years every time. Changing the todayDate we can make it easier.

How Has This Been Tested?

Tests were made in browser through UI.
Tested on MacOS Sierra, Chrome 57.0.2987.98 (64-bit)

Screenshots:

screen shot 2017-04-12 at 16 21 12
screen shot 2017-04-12 at 16 21 18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tests were already failing

@wehriam
Copy link
Contributor

wehriam commented Jun 19, 2017

Hi @gReis89 - thanks for the PR! Please review the conflicts when you have a chance.

@gReis89
Copy link
Author

gReis89 commented Jun 19, 2017

@wehriam conflicts solved, have added unit testing, but some existing are still not passing

@wehriam
Copy link
Contributor

wehriam commented Jun 19, 2017

Hi @gReis89 - All tests are passing on master.

I merged in #124 which seems to have created some additional conflicts.

Can you pull from the most recent version, make sure your dependencies are up to date, and try again?

@gReis89
Copy link
Author

gReis89 commented Jan 19, 2018

Hey @wehriam!

Branch updated with pushtell/master, conflicts are solved out and tests are working now.
I had to add a default a dataFormat property to one of the tests due to different date formats around the globe(mine is "DD/MM/YYYY" and tests were matching for "MM/DD/YYYY")

Is that possible to release this PR in any moment soon? planing to use it on my next sprint, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants