Don't minify for printing size if --info is not requested #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was always minifying the input with `clean-css`, and then discarding it if `options.info` was not set. Running purifycss without `options.info` on a [small app using tachyons](https://github.com/choojs/bankai/tree/master/example): - Before: 302.531ms - After: 133.599ms
|
This is a cheap fix with big gains—any chance of getting it in soon? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purifycss/src/purifycss.js
Line 38 in d8a29b4
This line was always minifying the input with
clean-css, and thendiscarding it if
options.infowas not set.Running purifycss without
options.infoon asmall app using tachyons:
(Built bundle.js and bundle.css files used for this comparison: https://gist.github.com/goto-bus-stop/40b6b39ed34bd215c8dd0ed274cd2230)