Selector regex fix #130
Open
Selector regex fix #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original regex did not cover all valid class selectors. The new one does - it adds support for integers, capital letters, underscores and dashes.
|
OK, I've added a commit that fixes that problem. Unfortunately, this breaks one of the existing tests. I'm afraid I don't have the time to hunt down this bug as well. I suspect that with the new regexp, the "join" glue is captured (which probably suggests that there might be more false positives). |
|
Is this still active? Escaped selectors still aren't being removed even when unused. |
|
Would love to see this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves the following:
Note: I didn't do negative testing, so these changes might mean that some other errant selector passes the new regex pattern and gets included when it shouldn't. But I don't think that likely.
EDIT: Hmm, apparently it now allows certain selectors when it shouldn't. Gonna fix that and reopen the PR after I make the changes.