Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web-page-visibility #203

Merged
merged 2 commits into from May 4, 2022

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Aug 20, 2021

purescript-web-page-visibility is a wrapper for the W3C Page Visibility spec. v2.0.0 tag build passed (Nix + Flakes + Cachix, merely builds as there is not much to test).

builds.sr.ht status

I have a future plans with this library, but one thing I really wanted to test is the Registry handling non-GitHub git repository—this will be the first repository. Sourcehut’s read-only Git cloning URI is https://git.sr.ht/ownerCanonicalName/repositoryName without .git (in fact, putting .git will return a 403). As Git is distributed, I will be excited to see what will happen in the future as others see examples of packages on multiple platforms.

Pursuit doc upload though will be blocked by Pursuit #422 and whatever happens there. This may be blocked by #204 which I opened for Sourcehut-specific support or #15 which allows arbitrary git repo support.

@f-f
Copy link
Member

f-f commented Aug 21, 2021

Right now the Registry is in a transitional state where we're trying to keep compatibility with Bower as much as we can. Is it possible to install this package with Bower from the SourceHut URL?

@toastal
Copy link
Contributor Author

toastal commented Aug 22, 2021

install this package with Bower

I'm not entire sure what this means? I know I can't register.

$ bower register purescript-web-page-visibility https://git.sr.ht/~toastal/purescript-web-page-visibility                                                                     web-page-visibility 
bower purescript-web-page-visibility#*          resolve https://git.sr.ht/~toastal/purescript-web-page-visibility#*
bower purescript-web-page-visibility#*         download https://git.sr.ht/~toastal/purescript-web-page-visibility
bower purescript-web-page-visibility#*         resolved https://git.sr.ht/~toastal/purescript-web-page-visibility
? Registering a package will make it installable via the registry (https://registry.bower.io), continue? Yes
bower purescript-web-page-visibility           register https://git.sr.ht/~toastal/purescript-web-page-visibility
bower                                          EUNKNOWN Unknown error: 500 - Registering bower package names is not supported anymore. You can install any bower package on github with command like "bower install jquery/jquery-dist --save"
$ bower install https://git.sr.ht/~toastal/purescript-web-page-visibility
bower cached        https://git.sr.ht/~toastal/purescript-web-page-visibility
bower validate      https://git.sr.ht/~toastal/purescript-web-page-visibility#*
bower new           version for https://git.sr.ht/~toastal/purescript-web-page-visibility#*
bower resolve       https://git.sr.ht/~toastal/purescript-web-page-visibility#*
bower download      https://git.sr.ht/~toastal/purescript-web-page-visibility
bower resolved      https://git.sr.ht/~toastal/purescript-web-page-visibility
bower install       purescript-web-page-visibility

Downloaded, but left a HTML-rendered README as the index in bower_components

$ bower install https://git.sr.ht/~toastal/purescript-web-page-visibility#v1.0.1
bower ENORESTARGET  URL sources can't resolve targets

Tag failed.

To be truthful, I'm by no means a bower expert and the docs seem to be screaming to go away at this point. I tried reading some of the pulp source to understand but gave up.

@f-f
Copy link
Member

f-f commented Aug 26, 2021

I'm not entire sure what this means? I know I can't register

Yeah, I meant running bower install $repo_url as you did. Unfortunately it looks like it doesn't work, but I'm no bower expert either.
If it turns out that we cannot make it work then I think we cannot add this package as it is - until the Registry is in a transitional state we are committed to keep all packages installable by Bower users.

@JordanMartinez
Copy link
Contributor

Per Bower's docs, does updating the URL to the below work?

https://git.sr.ht/~toastal/purescript-web-page-visibility/archive/v1.0.4.tar.gz

@toastal
Copy link
Contributor Author

toastal commented Mar 1, 2022

I could give this a look, but it's not very high on my priorities this second. When I did this, I was using PureScript every day for work and now that I'm not, PureScript is back to hobby status for now.

@toastal toastal force-pushed the web-page-visibility branch 2 times, most recently from 375d347 to c178bdf Compare May 2, 2022 03:17
@toastal
Copy link
Contributor Author

toastal commented May 2, 2022

Tried this. Registering is no longer supported. The installing however did work.

@JordanMartinez JordanMartinez merged commit a77d869 into purescript:master May 4, 2022
@toastal
Copy link
Contributor Author

toastal commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants