Docker workdir support

[jordanpwalsh]

This adds an additional optional parameter to the "remote" configuration allowing the working directory to be set during invocation of docker exec. I was originally working around needing to execute the runCommand in an appropriate working directory by running a shell script but thought an option in the config would be beneficial to prevent needing to add those scripts to the source repository.

Testing output:

Relevant config:

"launch": {
	"remote": {
		"container": "${ContainerID}",
		"workdir": "/opt/app-root/src/pyluglite",
		"runCommand": ["pwd"]
	},
...

Output:

 /opt/app-root/src/pyluglite

[puremourning]

This change is 

[jordanpwalsh]

Closing due to accidental code reformatting.

[jordanpwalsh]

Re-opened with the file not completely reformatted.

[puremourning]

Thanks for sending a PR but I fear this might be a slippery slope to implementing the entire compose file specification, or at least every argument to docker exec. I would prefer either:

• just use simple command and run docker exec manually
• add a docker_args or something akin to the ssh_args or whatever we already have.

[jordanpwalsh]

If you prefer, I can implement your option 2 instead; I personally prefer that over a custom command. I would like to push back a little though. I can see your point about not wanting to implement a bunch of the compose spec, but I’d argue this isn’t quite that. The docker exec options are quite small — user id, env vars, and working directory — and I could easily see the other two being something to include as well. Working directory is just the one I happened to need at the time.

All that said. Your option of docker_args would suit me just fine too. I’m happy to help.

[puremourning]

That's sort of my point. It's a bit whack-a-mole. I'd rather have option 2 which is just a list of additional args passed to docker exec. Then I never have to change it again if/when docker or podman inevitably change or add something.

[jordanpwalsh]

Sounds good. I’ll update the PR.

[jordanpwalsh]

I updated the branch per your feedback. I thought a format like below would be more intuitive, but opted to use docker_args from your original suggestion so existing configs aren't broken.

What I wanted:

"container": {
    "name": "string",
    "args": ["string", "string"]
}

What I did:

{
    "container": "string"
    "docker_args": ["string", "string"]
}

[puremourning]

I think what you wanted was fine, and probably better. We could have doe that with a "if it's an object, then ... else ..." but this is also ok.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

[puremourning]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jordanpwalsh)

[jordanpwalsh]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jordanpwalsh)

[jordanpwalsh]

@puremourning I fixed the couple linter complaints. Anything needing to be done about the failing test? Looks like the mac os test failing has been an ongoing thing.

[jordanpwalsh]

Reviewed 1 of 2 files at r3, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jordanpwalsh)

[puremourning]

I've kicked the CI. Fingers crossed 🤞

[puremourning]

Looks like a lint issue

[jordanpwalsh]

@puremourning I don't have your flake8 config and no errors on my end, but I think I found what it was complaining about and fixed it.

[jordanpwalsh]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jordanpwalsh)

[puremourning]

@Mergifyio rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/8)
Auto-merging python3/vimspector/debug_session.py
CONFLICT (content): Merge conflict in python3/vimspector/debug_session.py
error: could not apply c3c2503... Added workdir support for docker exec
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply c3c2503... Added workdir support for docker exec