WIP: Data breakpoints #765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
puremourning
force-pushed
the
data-breakpoints
branch
3 times, most recently
from
48a5679
to
51d0bad
Compare
Works with CodeLLDB mostly for named things. Expressions don't seem to be supported by anyone. Fixed some state issues with the connections being retained across restarts in watches. ugh. so messy. Added access type question.
…nd anything if there's a connected session
puremourning
force-pushed
the
data-breakpoints
branch
from
51d0bad
to
e6b80c4
Compare
puremourning
commented
May 24, 2023
| continue | ||
| if bp[ 'conn' ] != connection.GetSessionId(): | ||
| continue | ||
| if not bp[ 'info' ].get( 'dataId' ): |
There was a problem hiding this comment.
could 0 be a valid value?
| @@ -91,6 +91,7 @@ | |||
| 'delete': [ '<Del>' ], | |||
| 'set_value': [ '<C-CR>', '<leader><CR>' ], | |||
| 'read_memory': [ '<leader>m' ], | |||
| 'add_data_breakpoint': [ '<F9>' ], | |||
There was a problem hiding this comment.
this should probably be based on the mappings mode, but I'm not sure anyone uses anything other than HUMAN mode...
| variable: Expandable | ||
| view: View | ||
|
|
||
| variable, view = self._GetVariable( buf, line_num ) |
There was a problem hiding this comment.
I guess this is where we might decide that it's actually an expression data BP e.g. we add a watch like foo and we want a data bp on the foo variable, but we currently can only do it on the result of that expression.
We should also allow it from the command line like :VimspectorAddDataBreakpoint <expression>
I will probably need to implement that for CodeLLDB before it's worth adding to vimspector as I still haven't found an adapter that supports it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.