Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doautocmd VimspectorJumpedToFrame after cursor moved #745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timsu92
Copy link
Contributor

@timsu92 timsu92 commented Apr 9, 2023

Before, this autocmd is called only when moved to a file but not after cursor is move as well. This PR resolves this.

This is inspired when solving #679 (comment) and that suggestion wasn't success. That's because this wasn't executed:

utils.SetCursorPosInWindow( self._window,
frame[ 'line' ],
frame[ 'column' ] )

However, I see this before it:
if should_jump_to_location:
utils.JumpToWindow( self._window )

I'm not sure whether SetCursorPosInWindow should be located inside the if.

@puremourning
Copy link
Owner

This change is Reviewable

@timsu92
Copy link
Contributor Author

timsu92 commented Apr 9, 2023

Or, do you think I should make this line in to a try...except vim.error block?

Copy link
Owner

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we update tests/ui.test.vim so that it tests this new behaviour (and would fail before this change) ?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@puremourning puremourning added the abandoned PR next action is with contributor, but seems to be abandoned label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned PR next action is with contributor, but seems to be abandoned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants