Accept ffi >= 1.16.3, < 1.17.0 #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it was fixed in 1.16.3. See puppetlabs/facter#2707
3 tasks
mhashizume
approved these changes
Apr 25, 2024
mhashizume
added
maintenance
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9330-to-7.x origin/7.x
cd .worktree/backport-9330-to-7.x
git checkout -b backport-9330-to-7.x
ancref=$(git merge-base fa213f5808c271c9e30fce04779489806fc93da7 aa513403255081f315de7dbdda8aaae1016ee036)
git cherry-pick -x $ancref..aa513403255081f315de7dbdda8aaae1016ee036 |
|
We'll need to wait for the changes in #9325 to get backported to 7.x before we can backport these FFI changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi 1.16.0 - 1.16.2 had a bug when defining a layout in an FFI::Struct and it was fixed in 1.16.3.
See puppetlabs/facter#2707