Fixes #9220: Accept environment names consisting only of integers.

[saimonn]

See #9220 for motivations behind this pull-request

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[CLAassistant]

All committers have signed the CLA.

[joshcooper]

Hi thanks for your PR, but unfortunately we've had issues in the past with confusion between symbols and strings in environment names. We don't want to reintroduce string-based names. See a6e0a6b and ceb7c01

I think you'll want to add some debugging to

puppet/lib/puppet/network/http/api/indirected_routes.rb

Line 36 in 3192f4a

indirection, method, key, params = uri2indirection(request.method, request.path, request.params)

to see if puppetserver is passing the environment request parameter as an integer when calling into puppet? Or if something in the indirected routes is coercing the string to an integer. It should be a string by the time we reach

puppet/lib/puppet/network/http/api/indirected_routes.rb

Line 62 in 3192f4a

environment = params.delete(:environment)

It's probably this

puppet/lib/puppet/network/http/handler.rb

Line 197 in 52903c2

Integer(value)

Probably want to special case environment since we know that shouldn't be coerced to integer and we don't want to break compatibility.

[joshcooper]

Hi @saimonn have you had a chance to review my comments? We'd welcome a pull request if you can incorporate those changes, thanks!

[saimonn]

Hi @joshcooper, thanks for the reminder!

I don't have enough time nor ruby knowledge to dig further on this PR.

We ended by prefixing our branches/environment names with letters as a workaround.

You can close this PR unless you find someone else with resources to address it.

[joshcooper]

Ok, thanks for letting us know. I'm going to close this for now.