Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix school name wrap #1601

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yash-learner
Copy link
Member

@yash-learner yash-learner commented Apr 29, 2024

Proposed Changes

Additional

  • Improve the footer responsiveness on small devices

@pupilfirst/developers
@pupilfirst/designers

Did not update the text on the left nav of admin as it is square and responsive.

fix-school-name-wrap.mp4

Merge Checklist

Not applicable

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
    • If the documentation updates include images, ensure they are compressed.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.
  • If the updates involve adding a new table ensure that rate limiting is added and documented in the docs/developers/rate_limiting.md file.

@yash-learner yash-learner marked this pull request as ready for review May 31, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow of the elements when a school name is long and does not have a logo
1 participant