Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to the subject of certificate issuance email #1553

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

harigopal
Copy link
Member

@pupilfirst/developers Similar to #1535, this adds the name to the subject of the certificate issuance sent to students. The main advantage here is that students replying to the issuance email will do so with a custom Re: SUBJECT, forcing the emails to not get clubbed in the school's mailbox.

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.
  • If the updates involve adding a new table ensure that rate limiting is added and documented in the docs/developers/rate_limiting.md file.

Copy link

cloudflare-pages bot commented Feb 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd18aec
Status: ✅  Deploy successful!
Preview URL: https://a48d5254.pupilfirst-docs.pages.dev
Branch Preview URL: https://add-name-to-subject-2.pupilfirst-docs.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant