-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort of courses on the home page #1532
Conversation
4866748
to
b6b73a6
Compare
@ramzieus Could you please complete the default checklist? Also, add specs for this feature as well. |
@vinutv @irajsuhail Could you please have a look at this whenever you're free. |
|
@kaisersakhi spec added |
@yash-learner done |
Please check the updated design for the admin dashboard |
@irajsuhail good and useful design |
@yash-learner It looks like this is already managed in the UI? The top course only shows the down arrow, and the bottom course only shows the up arrow. 🤔
There doesn't seem any harm in it. 🤷🏼♂️
I think we can gradually apply the use of
It shouldn't have any special effect. Even when any filter is applied, the resulting list needs to be ordered by something - that something is the
Not absolutely necessary to get this merged, I think. Skip for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on latest changes
It looks like this is already managed in the UI? The top course only shows the down arrow, and the bottom course only shows the up arrow. 🤔
Not handled in UI when the page is paginated
We decided not to swap the last course in the loaded courses with the first course of unloaded courses in pagination.
It shouldn't have any special effect. Even when any filter is applied, the resulting list needs to be ordered by something - that something is the sort_index now.
Yes
Not absolutely necessary to get this merged, I think. Skip for now?
Yes
I think we can gradually apply the use of courses.sort_index.
Yes
@yash-learner I opted not to show the Move down option for the last entry in the list, regardless of whether it's fully loaded or partially loaded. This small change allows the existing UI code to work as intended. The Move down option will appear on last loaded entry if more are loaded beneath it. |
Thank you, @ramzieus, for the contribution 🙌 |
Proposed Changes
@pupilfirst/developers
@pupilfirst/designers
Merge Checklist
Check if new tables or columns that have been added need to be handled in the following services:Check if changes in packaged components have been published tonpm
.Add development seeds for new tables.If the updates involve adding a new table ensure that rate limiting is added and documented in thedocs/developers/rate_limiting.md
file.