Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the conditional check when retrieving the thumbnail image in course_type #1580

Closed
yash-learner opened this issue Mar 11, 2024 · 0 comments · Fixed by #1532
Closed

Fix the conditional check when retrieving the thumbnail image in course_type #1580

yash-learner opened this issue Mar 11, 2024 · 0 comments · Fixed by #1532
Labels
bug Something isn't working

Comments

@yash-learner
Copy link
Member

Describe the bug
Fix the conditional check when retrieving the thumbnail image in course_type. The thumbnail method checks for the presence of the cover image when getting a course, this causes the thumbnail, not to render in school courses index page even though the course has a thumbnail image and no cover image.

To Reproduce
Steps to reproduce the behavior:

  1. Create a course with a thumbnail but no cover image and refresh the page.
  2. Course card will not have a thumbnail image even though it has a thumbnail image but you can see the thumbnail image on student pages

Expected behavior
The course card should have the thumbnail image.

@yash-learner yash-learner added the bug Something isn't working label Mar 11, 2024
yash-learner added a commit to yash-learner/pupilfirst that referenced this issue Mar 11, 2024
@harigopal harigopal linked a pull request Mar 20, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant