Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #on_stopped DSL (re: discussion/3379) #3380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add #on_stopped DSL (re: discussion/3379) #3380

wants to merge 1 commit into from

Conversation

emilyst
Copy link

@emilyst emilyst commented May 6, 2024 •
edited

Description

This change adds the #on_stopped method to Puma's DSL, to match the functionality provided by #on_booted. Since this DSL method is documented, its absence appears to be a simple oversight, and it seems appropriate to have.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@emilyst
Add #on_stopped DSL (puma#3379)
77f9f82 
This change adds the `#on_stopped` method to Puma's DSL, to match the
functionality provided by `#on_booted`. Since this DSL method is
documented, its absence appears to be a simple oversight, and it seems
appropriate to have.
@johnnyshields
Copy link
Contributor

LGTM

@joshuay03 joshuay03 mentioned this pull request May 7, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilyst @johnnyshields