Raise an ArgumentError unless a hook is called with a block
#3377
+42
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
joshuay03
changed the title
ArgumentError unless a hook is called with a block
|
Should this be considered a breaking change and introduced with Puma 7? |
That makes sense to me 👍🏽 I think #3376 is fine to release before that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite: #3376
I don't see why hooks should be processed if a block is not given, and if it's being called that way it could be due to user error. This ensures an
ArgumentErroris raised unless a block is given when configuring hooks.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.