Make installation more robust #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helhum
force-pushed
the
cleanup-installation
branch
from
8732077
to
ddd31e7
Compare
|
|
||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why did you remove the try catch ?
There was a problem hiding this comment.
Hope the new version makes that more clear. The code executed does not throw a PuliRunnerException any more, thus the try/catch does not make sense any more. The exceptions that might be triggered really are fatals (mainly programming mistakes in the plugin), which should bubble up.
helhum
force-pushed
the
cleanup-installation
branch
from
ddd31e7
to
ff0f3d5
Compare
|
I'm now investigating why the build fails |
helhum
force-pushed
the
cleanup-installation
branch
from
ff0f3d5
to
8725599
Compare
* Remove autoload.php generation * Make using the puli/cli in the same project work
helhum
force-pushed
the
cleanup-installation
branch
from
8725599
to
069abe3
Compare
webmozart
reviewed
Oct 11, 2016
| } | ||
| switch ($key) { | ||
| case 'factory.in.file': | ||
| if (empty($config) || empty($config['config']['factory']['in']['file'])) { |
There was a problem hiding this comment.
Isn't the empty($config) implied by the right-hand-side of the condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by reading the puli.json directly for
the factory file and class name configuration (instead of running the puli cli, which is not ready yet
if it is installed in the same project).