Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module FA #908

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

GNaD13
Copy link

@GNaD13 GNaD13 commented Oct 23, 2023

This PR will

  • Add fee-abstraction module
  • Adjust globalfee ante to work compatible with fee-abstraction
    This PR is ready for review but probably right now it shouldn't be merged because we are completing the audit.

@GNaD13 GNaD13 marked this pull request as draft October 23, 2023 08:49
@GNaD13 GNaD13 marked this pull request as ready for review October 23, 2023 09:28
@jhernandezb
Copy link
Member

This is great thank you ! we will take a look

Copy link
Collaborator

@spoo-bar spoo-bar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just two main things

  1. The Feeabskeeper is not actually passed in to the ante handler options, so any tx would fail when mpog is non zero. Adding FeeAbskeeper: app.FeeabsKeeper, here should fix it

    stargaze/app/app.go

    Lines 861 to 867 in 505f915

    HandlerOptions: ante.HandlerOptions{
    AccountKeeper: app.AccountKeeper,
    BankKeeper: app.BankKeeper,
    SignModeHandler: encodingConfig.TxConfig.SignModeHandler(),
    FeegrantKeeper: app.FeeGrantKeeper,
    SigGasConsumer: ante.DefaultSigVerificationGasConsumer,
    },
  2. Adding the feeabs storekey to the upgrade handler

Minor:
Noticed you modified the go.mod go version to older one. Any specific reason why?

@GNaD13
Copy link
Author

GNaD13 commented Nov 3, 2023

LGTM

Just two main things

  1. The Feeabskeeper is not actually passed in to the ante handler options, so any tx would fail when mpog is non zero. Adding FeeAbskeeper: app.FeeabsKeeper, here should fix it

    stargaze/app/app.go

    Lines 861 to 867 in 505f915

    HandlerOptions: ante.HandlerOptions{
    AccountKeeper: app.AccountKeeper,
    BankKeeper: app.BankKeeper,
    SignModeHandler: encodingConfig.TxConfig.SignModeHandler(),
    FeegrantKeeper: app.FeeGrantKeeper,
    SigGasConsumer: ante.DefaultSigVerificationGasConsumer,
    },
  2. Adding the feeabs storekey to the upgrade handler

Minor: Noticed you modified the go.mod go version to older one. Any specific reason why?

Hi @spoo-bar. Thanks for your reviewed. I've updated to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants