Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement transition_to stats for the jira plugin #352

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lukaszachy
Copy link
Collaborator

@lukaszachy lukaszachy commented Jan 4, 2024

Should I make it more generic? As in 'JiraTransitioned' ? In theory one could have config with one project counting 'Release Pending' and another where 'Integration' is counted as the user's role is different

Config like

[jira-where-developer]
project = DEVEL
transition_state = 'Integration'

[jira-where-qe]
project = QE
transition_state = 'Release Pending'

Seems that states and workflows can be too different

@lukaszachy lukaszachy marked this pull request as draft January 4, 2024 15:55
@psss psss self-assigned this Jan 8, 2024
@psss psss added the jira label Jan 8, 2024
@psss psss added this to the 0.22 milestone Jan 8, 2024
@psss psss changed the title jira: Count verified issues Implement verified stats for the jira plugin Jan 8, 2024
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! The custom verified_status field looks good to me. Works nicely, I only ran into a problem when login contained @. Should be fixed by d339504.

@psss
Copy link
Owner

psss commented Jan 8, 2024

For reference, the reported error was:

Failed to fetch jira issues for query 'status changed to 'Release Pending' and status changed by psplicha@redhat.com after 2024-01-08 before 2024-01-15'.
The reason was 'Bad Request' and the error was 'Error in the JQL Query: The character '@' is a reserved JQL character. You must enclose it in a string or use the escape '\u0040' instead. (line 1, character 67)'.

@lukaszachy lukaszachy marked this pull request as ready for review February 1, 2024 08:39
@lukaszachy lukaszachy changed the title Implement verified stats for the jira plugin Implement transition_to stats for the jira plugin Feb 1, 2024
@jharuda
Copy link

jharuda commented Apr 11, 2024

@lukaszachy Your implementation makes sense, generally speaking. How about specifying important states by list variable in the config? I am just thinking how to make it more general for different Jira projects.

The idea of this issue #364 is to have for example something like this in the config:

[jira]
...
states=['Release pedning', 'In progress']
...

Default (without states variable in the config) behavior can be the same as it is now, which means generating only updates section to hide different states in the did output.

@psss
Copy link
Owner

psss commented Apr 11, 2024

List of interesting statuses sounds nice, it would give even a bit more flexibility to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants