Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement did last [monday..sunday] #342

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Implement did last [monday..sunday] #342

merged 1 commit into from
Mar 27, 2024

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Nov 20, 2023

Fixes: #305

@psss psss changed the title implement last [monday..sunday] Implement the last [monday..sunday] Dec 4, 2023
@psss psss changed the title Implement the last [monday..sunday] Implement did last [monday..sunday] Dec 4, 2023
@psss psss added the base label Dec 4, 2023
@psss psss added this to the 0.22 milestone Dec 4, 2023
@psss psss self-assigned this Dec 4, 2023
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the day selection. Looks good, only when selecting the last day which is the same as today results in today's report:

> date
Tue Dec  5 00:02:37 CET 2023

> did last tuesday
Status report for the last tuesday (2023-12-05 to 2023-12-05).
...

Could you please cover that use case as well? Thanks.

@psss
Copy link
Owner

psss commented Dec 13, 2023

Seems the last adjustment broke some intervals: After the change we get one week before the expected interval:

> date
Wed Dec 13 23:01:05 CET 2023

> did last friday
Status report for the last friday (2023-12-01 to 2023-12-01).

Failing tests confirm the problem.

@xsuchy
Copy link
Contributor Author

xsuchy commented Mar 25, 2024

Ping. Anything blocking this PR?

Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good. Thanks!

@psss psss merged commit cf62044 into psss:main Mar 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

did last friday - only friday supported?
2 participants