Give a reasonable error for unreachable wiki url #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
force-pushed
the
unreachable-wiki
branch
2 times, most recently
from
9cfc82c
to
3d45c37
Compare
lukaszachy
reviewed
Jun 30, 2023
There was a problem hiding this comment.
How about catching also xmlrpc errors?
This patch works for 'unreachable' however when I used example config ..
ERROR <Fault 1: 'This moin wiki does not allow xmlrpc method calls.'>
* Updates on wiki test: 0 changes of 0 pages
IMO it should handle that as well
|
Yeap, makes sense, fixed in 67cffa0. |
lukaszachy
approved these changes
Jul 11, 2023
Prevent traceback when wiki server is not reachable. Fix BZ#2118329.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent traceback when wiki server is not reachable. Fix BZ#2118329.