Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some paths moves into config #101

Open
wants to merge 20 commits into
base: lazy_load
Choose a base branch
from
Open

Some paths moves into config #101

wants to merge 20 commits into from

Conversation

Iworb
Copy link

@Iworb Iworb commented Feb 6, 2017

No description provided.

@Iworb
Copy link
Author

Iworb commented Feb 9, 2017

Implemented new view mode "split" (in filemanager.config.json -> options -> filemaagerMode = 'split').
In this view mode tree view will show only folders and main view - files only.
Also, important lazy-load changes applied.

@dereks
Copy link
Contributor

dereks commented Feb 10, 2017

Could you post a screenshot of the "Split view mode"?

@Iworb
Copy link
Author

Iworb commented Feb 10, 2017

Only folders in the tree model and only files in the main section.
2017-02-10_103025

listFiles works only with tree panel, but split mode includes main area

@dereks
Copy link
Contributor

dereks commented Feb 12, 2017

The screenshot does not show an expanded folder, so it's hard to see the feature in action. But I think it makes the tree show only dirs, and the main panel show only files...?

What is the white box in the upper left, covering most of the tree?

@@ -236,7 +236,7 @@ public function handleRequest()
break;

case 'getfolder':
if($this->getvar('path') && $this->getvard('skip', true, 0)) {
if($this->getvar('path') && $this->getvard('skip', true, 0) && $this->getvard('load', true, 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getvard()? Probably should be getvar().

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look for new function getvard which don't throw error if variable wasn't set. 3rd argument is default value which will be used if name not defined in $_GET.

@psolom
Copy link
Owner

psolom commented Feb 12, 2017

Hey @Iworb

Thanks for the commits. I am reviewing and can see that the implementation breaks some features, so I have to rewrite lazy loading in a bit different way, however I can use many of your ideas. Most likely I will have to close this PR, but feel free to continue commit changes if you have any. Your contribution is very valuable.

@Iworb
Copy link
Author

Iworb commented Feb 13, 2017

Heya, @servocoder

Okay, I think I will take a look for my own connector and than join to your lazy_loading branch again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants