tsdb/index: Refactor Reader tests #14071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/refactor-index-tests
branch
2 times, most recently
from
d49e617
to
78491c5
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/refactor-index-tests
branch
from
78491c5
to
54a3d1d
Compare
beorn7
requested changes
May 15, 2024
…ex-tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
|
Thanks for the review @beorn7 - I fixed the merge conflicts (and refactored |
…heus into arve/refactor-index-tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/refactor-index-tests
branch
from
2048290
to
fcd53ff
Compare
beorn7
approved these changes
May 16, 2024
|
Thank you, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
tsdb/index.Readertests and a benchmark, as they have a lot in common. Pulled out of #13620, as the refactor became irrelevant there :)I think the tests/benchmark become much more maintainable and easier to understand after this refactoring.